feat(chat bubbles): reactively update sender name - WPB-19514 #3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/CB-4-update-sender-name # Conflicts: # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesDataSource.swift
# Conflicts: # WireMessaging/Sources/WireMessagingAssembly/ConversationsAssembly.swift # WireMessaging/Sources/WireMessagingDomain/Conversation/LoadConversationMessagesUseCase.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesDataSource.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesViewController.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesViewModel.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Content/LoadConversationMessagesRepository.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/ConversationViewController.swift
…e/CB-4-update-sender-name
dmitrysimkin
requested review from
a team,
jullianm and
samwyndham
and removed request for
a team
samwyndham
reviewed
Aug 18, 2025
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/MessagesIndividualUpdatesFactory.swift
Show resolved
Hide resolved
Base automatically changed from
feature/CB-3-handle-message-send-WPB-19373
to
develop
August 21, 2025 15:52
# Conflicts: # WireMessaging/Sources/WireMessagingAssembly/ConversationsAssembly.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationDataSource.swift # WireMessaging/Sources/WireMessagingUI/Conversation/ConversationMessagesViewController.swift # wire-ios/Wire-iOS/Sources/UserInterface/Conversation/ConversationViewController.swift
jullianm
approved these changes
Aug 22, 2025
Contributor
jullianm
left a comment
jullianm
left a comment
There was a problem hiding this comment.
Nice work! left a question
...essaging/Sources/WireMessagingUI/Conversation/Message Views/SenderView/SenderViewModel.swift
Show resolved
Hide resolved
samwyndham
approved these changes
Aug 29, 2025
samwyndham
changed the title
netbe
reviewed
Oct 17, 2025
Collaborator
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
Also looks good, just wonder if we can remove the performAndWait
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/SenderObserver.swift
Show resolved
Hide resolved
netbe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Added logic to handle when user name changed, by introducing one publisher per user (one subject and sever cell's view models as subscribers.
Testing
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-08-13.at.18.50.17.mp4